docs: Replace SFTTrainer with RewardTrainer in comment#589
Merged
lvwerra merged 1 commit intohuggingface:mainfrom Jul 28, 2023
Merged
docs: Replace SFTTrainer with RewardTrainer in comment#589lvwerra merged 1 commit intohuggingface:mainfrom
lvwerra merged 1 commit intohuggingface:mainfrom
Conversation
Likely just a copy-paste error
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
approved these changes
Jul 28, 2023
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
Likely just a copy-paste error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
SFTTrainerwithRewardTrainerin a comment inreward_trainer.py.Details
It was likely just a copy-paste error - this speaks for itself.
We can also just refactor this comment (and the one from
sft_trainer.py), as they don't make much sense.