[CHAPTER 15] typo in scene.vert initTangent set twice, second time should be initBitangent

[wierdest]

This is the code for the scene.vert in the chapter 15:

            vec4 tmpTangent = bonesMatrices[boneIndex] * vec4(tangent, 0.0);
            initTangent += weight * tmpTangent;

            vec4 tmpBitangent = bonesMatrices[boneIndex] * vec4(bitangent, 0.0);
            initTangent += weight * tmpBitangent;  // this should be initBitangent += ... Right?

I believe the initTangent is being set twice, and it should be replacecd by initBitangent
...
Another question about the chapter (more a question than an issue, really):
has it been tested for animations in the gltf format?
I'm able to load the animation data, and logs for the nextFrame() calls return sucessfully, but the animation never plays.
Thanks in advance.

[lwjglgamedev]

Yes, it seems a typo. I will try to upload a fix this weekend.

Regarding your GTLF question, it should work the same way. I can try to test with some example. However, the code is quite similar to the one used in the vulkan book, which I've tested with GTLF models (you have a working example here, although this uses compute shaders, the way to process animations should be more or less the same).

[wierdest]

About the gltf, YES! It works perfectly! The way I was exporting was the problem! Thanks so much!

[lwjglgamedev]

Fixed. Thanks for reporting. Keep on reviewing !