Make sure compatibility macros are defined before use#2
Merged
brauner merged 1 commit intolxc:masterfrom May 8, 2018
Merged
Conversation
PKG_CHECK_VAR is only available in >=pkg-config-0.28. To allow the configure script to be executed on a distribution with a lower pkg-config version (e.g. CentOS 7) it is also defined locally. However so far it is defined after being used, so it would result in an error such as: configure.ac:61: error: possibly undefined macro: PKG_CHECK_VAR Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lua-lxc-3.0.0fails to be built on CentOS 7. See ganto/copr-lxc3#2. To fix this, I had to move around the code definingPKG_CHECK_VAR.