Skip to content

Fix tool_utils.c build when HAVE_SETNS is unset#2291

Closed
pkun wants to merge 2 commits intolxc:masterfrom
pkun:master
Closed

Fix tool_utils.c build when HAVE_SETNS is unset#2291
pkun wants to merge 2 commits intolxc:masterfrom
pkun:master

Conversation

@pkun
Copy link
Contributor

@pkun pkun commented Apr 26, 2018

When HAVE_SETNS is unset the tool_utils.c can't be build because it can't find setns(). The inline setns() is defined in lxc/utils.h but isn't defined in lxc/tools/tool_utils.h. The patch fixes it. Another minor patch fixes headers in lxc/tools to use their own defines to disable double including ( __LXC_TOOLS_UTILS_H).

@lxc-jenkins
Copy link

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@brauner
Copy link
Member

brauner commented Apr 26, 2018

Thanks for the patch but before I can even look at it you need to sign-off your commits kernel DCO style. Should be as easy as git commit -s.

@brauner brauner added the Incomplete Waiting on more information from reporter label Apr 26, 2018
@pkun pkun closed this Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Incomplete Waiting on more information from reporter

Development

Successfully merging this pull request may close these issues.

3 participants