Skip to content

Version 1.2.1

Choose a tag to compare

@mre mre released this 08 Feb 11:37
· 153 commits to master since this release

Fix evaluating glob patterns

Glob patterns were not properly evaluated for three reasons:

  1. Quotes around globs were not preserved. As a result, unquoted wildcards were evaluated by bash instead of lychee
  2. ** patterns handled by the glob crate need to be prefixed with a separator, e.g. ./. See code here and here. We should probably switch to globset at some point, which doesn't have that limitation.
  3. The lychee command itself needs to be executed with eval to make it find links. Otherwise it interprets the input argument (${ARGS[@]}) as a string and tries to find links within that string. (String input is supported by lychee). We want to interpret it as individual (whitespace-separated) arguments however. (Note that Github Actions doesn't support arrays as inputs, which prevents us from using array splitting.)

Recommended usage inside pipelines: Surround glob patterns with single quotes and prefix them with ./.

- name: Link Checker
  uses: lycheeverse/lychee-action@v1.1.1
  with:
    # Check all Markdown and HTML files
    args: --verbose --no-progress './**/*.md' './**/*.html'

For more context, see #67 and #68.
The examples have been updated accordingly.