Fix `test_exclude_example_domains`

[thomas-zahner]

In the past I stumbled upon the test test_exclude_example_domains. And just now I did again because weirdly enough it is excluded in the Makefile explicitly unlike any other test. After a little investigation I realised that the test fails with certain feature flags. This was probably the reason the test was excluded because it seemed flaky.

To reproduce cd into lychee-bin and then:

$ cargo test -- test_exclude_example_domains

test cli::test_exclude_example_domains ... ok

$ cargo test --all-features -- test_exclude_example_domains

test cli::test_exclude_example_domains ... FAILED

[mre]

I think it's because this is an integration test on the CLI. We skip example domains in the final lychee CLI itself.

[mre]

Oh, I get it now. Guess we could remove the test. 👍

[thomas-zahner]

Or what about just adding #[cfg(not(the-specific-feature-flag-that-causes-this)] to the test. This should probably work, right?

[thomas-zahner]

Found the flag. It was check_example_domains which makes quite a lot of sense, I think 🙂

[mre]

Makes sense! Thanks!