Merged
Conversation
Release 1.3.7
the caching mechanism for the transition matrix and observation matrix did not work before since they used non-hashable types (dicts) as part of the key. Changed to use tuples instead. Further the transition matrix did not account for parameter changes, now fixed by including edges as part of the cache key.
Furthe improved HPV risk call and variable names
…into feat/fix_caching
Fixed shortcomings from the latest update. The model works correctly now, though some improvements could still be made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this merge we fixed some caching issues, updated the get started file and made some improvements on the HPV model