Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

ui v2: storybook upgrade and config improvements#695

Merged
danielhochman merged 4 commits intoUIV2from
uiv2-storybook-upgrade-config
Nov 19, 2020
Merged

ui v2: storybook upgrade and config improvements#695
danielhochman merged 4 commits intoUIV2from
uiv2-storybook-upgrade-config

Conversation

@danielhochman
Copy link
Collaborator

@danielhochman danielhochman commented Nov 19, 2020

Description

Made some changes to config to get all props to appear.

From https://www.npmjs.com/package/storybook-addon-react-docgen#faq I also learned that React must be imported like so when using React.FC:

import * as React from 'react'; // GOOD
import React from 'react'; // BAD

and a default export is not good enough, the component must also be exported or the props will not appear.

To demo I fixed the Button and its story.

Before
Screenshot from 2020-11-19 11-33-26

After
Screenshot from 2020-11-19 11-35-35

@danielhochman danielhochman requested a review from a team as a code owner November 19, 2020 17:42
@danielhochman danielhochman merged commit 1b49ada into UIV2 Nov 19, 2020
@danielhochman danielhochman deleted the uiv2-storybook-upgrade-config branch November 19, 2020 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant