Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

ui v2: accordion#735

Merged
dschaller merged 7 commits intoUIV2from
ui-v2-accordion
Dec 4, 2020
Merged

ui v2: accordion#735
dschaller merged 7 commits intoUIV2from
ui-v2-accordion

Conversation

@danielhochman
Copy link
Collaborator

@danielhochman danielhochman commented Dec 2, 2020

Description

Accordion component

Testing Performed

Storybook

TODOs

  • Discuss border and shadow with designer
  • 1px gap (subpixel rounding?) issue
  • add'l stories

@danielhochman danielhochman marked this pull request as ready for review December 4, 2020 17:40
@danielhochman danielhochman requested a review from a team as a code owner December 4, 2020 17:40
Comment on lines +44 to +53
const AccordionSummaryBase = ({ children, collapsible, expanded, ...props }) => {
return (
<MuiAccordionSummary
expandIcon={collapsible ? expanded ? <RemoveIcon /> : <AddIcon /> : null}
{...props}
>
{children}
</MuiAccordionSummary>
);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const AccordionSummaryBase = ({ children, collapsible, expanded, ...props }) => {
return (
<MuiAccordionSummary
expandIcon={collapsible ? expanded ? <RemoveIcon /> : <AddIcon /> : null}
{...props}
>
{children}
</MuiAccordionSummary>
);
};
const AccordionSummaryBase = ({ children, collapsible, expanded, ...props }) => (
<MuiAccordionSummary
expandIcon={collapsible ? expanded ? <RemoveIcon /> : <AddIcon /> : null}
{...props}
>
{children}
</MuiAccordionSummary>
);

@dschaller dschaller merged commit ad50254 into UIV2 Dec 4, 2020
@dschaller dschaller deleted the ui-v2-accordion branch December 4, 2020 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants