This repository was archived by the owner on Feb 13, 2026. It is now read-only.
Merged
Conversation
dschaller
reviewed
Dec 7, 2020
dschaller
reviewed
Dec 7, 2020
| }; | ||
|
|
||
| export interface AccordionGroupProps { | ||
| children: React.ReactElement | React.ReactElement[]; |
Contributor
There was a problem hiding this comment.
Suggested change
| children: React.ReactElement | React.ReactElement[]; | |
| children: React.ReactElement; |
Collaborator
Author
There was a problem hiding this comment.
This JSX tag's 'children' prop expects a single child of type 'ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)>) | (new (props: any) => Component<any, any, any>)>', but multiple children were provided.ts(2746)
Collaborator
Author
There was a problem hiding this comment.
(worked for node but not for element)
Contributor
There was a problem hiding this comment.
ah sorry I misread this as ReactNode
dschaller
approved these changes
Dec 7, 2020
danielhochman
force-pushed
the
ui-v2-accordion-group
branch
from
7afa361 to
7274085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a mutually exclusive expanded accordion group.
Testing Performed
Storybook.