Conversation
scarlettperry
force-pushed
the
sperry-sidebar
branch
2 times, most recently
from
a3278ba to
10c53ed
Compare
| import Header from "./header"; | ||
|
|
||
| const AppLayout: React.FC = ({ children }) => { | ||
| const Box = styled(MuiBox)({ |
There was a problem hiding this comment.
based this off a material ui drawer example https://material-ui.com/components/drawers/#mini-variant-drawer, sandbox. and for width: "calc(100% - 100px), I pattern matched AIM
danielhochman
left a comment
danielhochman
left a comment
There was a problem hiding this comment.
overall good, minor nits and qs
|
does the sidebar avatar color look too harsh in comparison to the app palate? or perhaps it's b/c the landing card avatars are lighter. should we ask in Figma for avatar mockups for both the sidebar and landing card? |
scarlettperry
force-pushed
the
sperry-sidebar
branch
from
bc85149 to
89a3186
Compare
|
RE #758 (comment), it's tricker than I thought. If you use the landing cards to navigate to a workflow, that needs to update the sidebar selected state too. Haven't figured out the right/clean way to achieve this. So for now, I have a simple selected state based on the open prop |
scarlettperry
force-pushed
the
sperry-sidebar
branch
from
89a3186 to
47e7ff3
Compare
scarlettperry
force-pushed
the
sperry-sidebar
branch
from
1220e52 to
0b32a1a
Compare
|
@dschaller latest commit addressed the content being hidden behind the sidebar. with these changes 2251bfc, the sidebar detaches from the header when the browser isn't full screen. I've been able to fix it by making the header position sticky with top 0. I didn't push that change up b/c still figuring out how to do it the right way with flex. |
| </Grid> | ||
| {trendingWorkflows.map(workflow => ( | ||
| <Grid item xs={12} sm={12} md={6} lg={4} xl={4}> | ||
| <Grid key={workflow.path} item xs={12} sm={12} md={6} lg={4} xl={4}> |
There was a problem hiding this comment.
This is just to fix a console warning. Unrelated from this PR but was on UIV2
|
@scarlettperry fixed the mobile layout position in 7e9abf0 |
|
@dschaller thank you for the help and corrections! looks beautiful 😍 |
3 participants
Description
PR
Testing Performed
locally,
make dev-mockTODOs
Groupcomponent