This repository was archived by the owner on Feb 13, 2026. It is now read-only.
Conversation
frontend/packages/core/src/tab.tsx
Outdated
| }, | ||
| "&:active": { | ||
| color: "rgba(13, 16, 48, 0.6)", | ||
| backgroundColor: "rgba(219, 219, 224, 1)", |
Contributor
There was a problem hiding this comment.
Suggested change
| backgroundColor: "rgba(219, 219, 224, 1)", | |
| backgroundColor: "#DBDBE0", |
Contributor
Author
There was a problem hiding this comment.
This is the rgb value :)
Contributor
|
for the single tab story, noticed that the selected tab doesn't have the bottom blue border |
Contributor
Author
|
yeah, the marker is only available on tabs. We can force the bottom border on selected but I think it doesn't make sense to since we already have it from the marker when activated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce tab & tabs components
Testing Performed
Storybook