Allow registering service/ip/port in discovery service

[RomanDzhabarov]

Currently pair of service name and ip needs to be unique, discovery service will overwrite settings when service/ip is non unique.

For example, if you register

service_name = service_1 ip = 127.0.0.1 port = 80 ... other tags, etc
service_name = service_1 ip = 127.0.0.1 port = 8080 ... other tags, etc

with discovery service, there only will be the latest entry saved (first one overwritten).

Delete logic relies on service/ip pair uniqueness as well.

[spullara]

I recommend this as well but it seems that Envoy is pretty keen on static ports. It would be nice to be able to bind 0 and then register the port you got rather than have them all statically configured and then you register both IP and port as suggested in this issue.

[mattklein123]

@spullara we will be fixing this sometime soon in this python implementation. On the Envoy side, there is nothing preventing a different discovery implementation from already doing this.

[spullara]

Ah, I see. I was tricked by all the other static ports in the configuration but those are really just for Envoy as opposed to the services that Envoy is proxying. Thanks for the clarification.

[sasinda]

If anyone needs a patch that quick fixes just the dynamodb backend for this issue, I attached here, (I tested for if post and get req work, and sweeping of hosts work. Did not do extensive testing, if it breaks other backend storages)
It changes the range key from ip address to endpoint (ip_address:port) in the primary key schema of Dynamodb table.
0001-fix-https-github.com-lyft-discovery-issues-22-multip.txt

[mikecutalo]

Thank you for you contribution to this repository.

Closing this Issue as this repository is being archived.