Skip to content

Animate command output timer digits#29

Merged
lynnswap merged 7 commits into
mainfrom
codex/command-timer-numeric-transition
Jun 6, 2026
Merged

Animate command output timer digits#29
lynnswap merged 7 commits into
mainfrom
codex/command-timer-numeric-transition

Conversation

@lynnswap
Copy link
Copy Markdown
Owner

@lynnswap lynnswap commented Jun 6, 2026

Purpose

  • Add a native AppKit rolling numeric transition to the active command-output timer.

Changes

  • Replace the timer attachment view with a custom layer-backed AppKit view.
  • Animate changed digits with clipped vertical slots while keeping non-numeric format changes stable.
  • Respect reduce-motion by disabling timer animations.
  • Add tests for digit transitions, width stability, long timer layout, and disabled animation.

Testing

  • swift test --build-system swiftbuild --no-parallel --filter commandTimerAttachmentView
  • swift test --build-system swiftbuild --no-parallel
  • xcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO
  • codex-review --base main

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bafcafddb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/ReviewUI/Detail/ReviewMonitorLogCommandOutputPanelView.swift Outdated
Copy link
Copy Markdown
Owner Author

@lynnswap lynnswap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@lynnswap lynnswap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@lynnswap lynnswap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap lynnswap merged commit 58af6df into main Jun 6, 2026
1 check passed
@lynnswap lynnswap deleted the codex/command-timer-numeric-transition branch June 6, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant