Merged
Conversation
ajroetker
approved these changes
Jun 26, 2021
sgarciapdx
approved these changes
Jun 26, 2021
epsniff
approved these changes
Jun 26, 2021
Contributor
epsniff
left a comment
epsniff
left a comment
There was a problem hiding this comment.
Oh shit... This makes me happy that we haven't bottomed out one finding a solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: lytics/lio#24378
I forgot that when gRPC experiences a deadline exceeded it doesn't return
context.DeadlineExceeded: it returnscodes.DeadlineExceededinside the error.This should probably fix our `can't register: already registered" issues (though it may lead to a ton of panics, which at least isn't a silent failure).