Skip to content

Fix grid leader errors #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajroetker merged 1 commit into from
Jul 6, 2021
Merged

Fix grid leader errors #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,11 @@ func (s *Server) startActorC(c context.Context, start *ActorStart) error {
timeout, cancel := context.WithTimeout(c, s.cfg.Timeout)
defer cancel()
if err := s.registry.Register(timeout, nsName); err != nil {
s.deregisterActor(nsName)
// Grid tries to start up leaders continuously so we need to ignore calling deregister
// otherwise we will deregister a leader out from under itself starting multiple leaders
if !(start.Type == "leader" && strings.Contains(err.Error(), registry.ErrAlreadyRegistered.Error())) {
s.deregisterActor(nsName)
}
return fmt.Errorf("registering actor %q: %w", nsName, err)
}

Expand Down