Skip to content

feat: merge adapters-internal into adapters package#17

Merged
prosdev merged 1 commit intomainfrom
feat/merge-adapters-internal
Nov 21, 2025
Merged

feat: merge adapters-internal into adapters package#17
prosdev merged 1 commit intomainfrom
feat/merge-adapters-internal

Conversation

@prosdev
Copy link
Copy Markdown
Collaborator

@prosdev prosdev commented Nov 21, 2025

Summary

This PR merges the @lytics/playwright-adapters-internal package into @lytics/playwright-adapters, consolidating all storage adapters into a single package.

Changes

  • ✅ Moved FirestoreAdapter from adapters-internal to adapters package
  • ✅ Added @google-cloud/firestore dependency to adapters package
  • ✅ Added ./firestore subpath export to adapters package.json
  • ✅ Updated all documentation to reference adapters instead of adapters-internal
  • ✅ Removed adapters-internal package directory
  • ✅ Updated config files (tsconfig.json, vitest.config.ts)
  • ✅ Added changeset for breaking change
  • ✅ All tests passing (128 tests)

Benefits

  • One less package to maintain - Reduces overhead
  • Simpler dependency management - All adapters in one place
  • Better discoverability - Users find FirestoreAdapter alongside other adapters
  • Still organized - Subpath exports (/firestore, /filesystem, /slack) maintain clean API

Migration

Before:

import { FirestoreAdapter } from '@lytics/playwright-adapters-internal/firestore';

After:

import { FirestoreAdapter } from '@lytics/playwright-adapters/firestore';

Breaking Change

⚠️ @lytics/playwright-adapters-internal package is removed. Use @lytics/playwright-adapters/firestore instead.

Testing

  • ✅ All tests pass (128 tests)
  • ✅ Build succeeds
  • ✅ Type checking passes

- Move FirestoreAdapter from adapters-internal to adapters package
- Add @google-cloud/firestore dependency to adapters
- Add ./firestore subpath export to adapters package.json
- Update all documentation to reference adapters instead of adapters-internal
- Remove adapters-internal package directory
- Update tsconfig.json and vitest.config.ts to remove adapters-internal references
- All adapters (filesystem, Slack, Firestore) now in single package
- Reduces maintenance overhead by consolidating packages

BREAKING CHANGE: @lytics/playwright-adapters-internal is removed.
Use @lytics/playwright-adapters/firestore instead.
@prosdev prosdev merged commit b5eb188 into main Nov 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants