Feature/change sequence flow style to enum#203
Merged
lyz-code merged 3 commits intolyz-code:mainfrom Jan 2, 2023
Merged
Conversation
rename SequenceStyle updated tests with new field updating git ignore rename SequenceStyle updated tests with new field updating git ignore Lint compatible code and test added a docstring for the enum converted to one-line docstring renamed the enum and fields as per @marcules suggestions lint compatible imports
adapters now use the new style_squence enums docs updated with SequenceStyle info
marcules
force-pushed
the
feature/change-sequence-flow-style-to-enum
branch
from
2de3b72 to
58b7eec
Compare
marcules
force-pushed
the
feature/change-sequence-flow-style-to-enum
branch
from
58b7eec to
cd112f5
Compare
Pull Request Test Coverage Report for Build 3818560840
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3818560840
💛 - Coveralls |
lyz-code
approved these changes
Jan 2, 2023
Owner
lyz-code
left a comment
lyz-code
left a comment
There was a problem hiding this comment.
Perfect contribution, thank you :)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #196, this resolves #198
This is a continuation of #198 - it adds tests and explicitly checks for the enum value and converts it to boolean, because the underlying library ruyaml expects bools for "sequence flow_style" to be either True (flow_style) or False (block_style).
Checklist