Skip to content

fix: classify external imports and native publish deps#81

Merged
lzehrung merged 6 commits into
mainfrom
fix/external-resolution-and-native-publish
May 3, 2026
Merged

fix: classify external imports and native publish deps#81
lzehrung merged 6 commits into
mainfrom
fix/external-resolution-and-native-publish

Conversation

@lzehrung
Copy link
Copy Markdown
Owner

@lzehrung lzehrung commented May 3, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves unresolved-import reporting by classifying “known externals” (stdlibs, URLs, and declared dependencies across several ecosystem manifests) and updates the release workflow to preserve generated native publish dependencies.

Changes:

  • Add an external specifier classifier and use it to filter unresolved imports based on stdlib/URL/manifest-declared dependencies.
  • Thread projectRoot through CLI/reporting paths so unresolved-import classification can consult nearby manifests.
  • Update release scripts/tests/docs to keep generated native optionalDependencies in the publish-ready manifest and document the new unresolved behavior.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/graphs/external-classifier.ts New classifier for external specifiers (stdlib/URL/declared-package/unresolved) with manifest parsing + caching.
src/graphs/queries.ts Updates getUnresolvedImports to use the new classifier and accept options.
src/cli.ts Passes projectRoot into unresolved import reporting for inspect and unresolved.
tests/graph-reports.test.ts Adds coverage for manifest-declared deps, scoped roots, stdlib/URL exclusions.
tests/cli-regressions.test.ts Adjusts CLI regression fixtures so inspect reflects the new unresolved filtering behavior.
scripts/release-lib.mjs Adds prepareNativePackageManifestForPublish helper to preserve generated optional deps.
scripts/release.mjs Adds a “publish-ready native package” write step before publishing native meta.
tests/release-script.test.ts Adds a unit test asserting native platform optional deps are kept in the publish manifest.
docs/cli.md Updates documentation for what inspect/unresolved exclude.
codegraph-skill/codegraph/SKILL.md Updates skill docs to mention codegraph unresolved and its exclusions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/graphs/external-classifier.ts Outdated
Comment thread src/graphs/queries.ts Outdated
Comment thread src/graphs/external-classifier.ts Outdated
Comment thread scripts/release.mjs
Comment thread scripts/release-lib.mjs Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/graphs/external-classifier.ts
Comment thread tests/graph-reports.test.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/graph-reports.test.ts
Comment thread tests/graph-reports.test.ts
Comment thread tests/graph-reports.test.ts
Comment thread tests/graph-reports.test.ts
Comment thread tests/graph-reports.test.ts
Comment thread tests/graph-reports.test.ts
Comment thread tests/cli-regressions.test.ts Outdated
Comment thread src/graphs/external-classifier.ts Outdated
Comment thread tests/graph-reports.test.ts
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/graph-reports.test.ts
Comment thread tests/graph-reports.test.ts Outdated
Comment thread src/graphs/external-classifier.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/graphs/external-classifier.ts
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lzehrung lzehrung merged commit f2b3f45 into main May 3, 2026
7 checks passed
@lzehrung lzehrung deleted the fix/external-resolution-and-native-publish branch May 6, 2026 05:14
lzehrung added a commit that referenced this pull request May 14, 2026
* fix: classify external imports and native publish deps

* fix: harden external classification and native publish

* fix: address external classifier review feedback

* fix: handle gitfile boundaries and temp cleanup

* test: isolate graph report fixtures

* fix: avoid exception-driven manifest probes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants