Added a function for VAD-segments to handle mp3 files, numpy arrays and tensors #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm curious: why do you ensure it's stereo? Doesn't the VAD under the hood use mono as well? |
Contributor
Author
As far as I remember then I had some problems when it were mono. It is however almost 2 months ago, and I think Max Bain has already solved this issue with other code. |
|
Nice improvement. Not sure about stereo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the function would let you parse numpy arrays and tensors. The VAD pipeline does however not support this, by just parsing, since you need to parse it as a mapping with the sample rate.
As of now you can't parse a mp3 file to the vad pipeline. I fixed this by reading the file with whisper audio_load and then converting it to stereo. This is not a pretty solution, but it seems to work quite well.