Skip to content

Conversation

@seokho-son
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 24, 2025 05:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates configuration files for the mc-infra-manager component to align with the latest version of cb-tumblebug. The changes modernize the database backend, update authentication settings, and add Kubernetes cluster support for cloud providers.

Key Changes:

  • Migration from SQLite to PostgreSQL database backend with updated connection parameters
  • Addition of Kubernetes cluster configuration for multiple cloud providers (AWS, GCP, Azure, Alibaba, Tencent, IBM, NHN, OpenStack, CloudIt)
  • Updated GitHub repository URLs and configuration parameter names to reflect current naming conventions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
conf/docker/conf/mc-infra-manager/setup.env Migrates database configuration from SQLite to PostgreSQL, adds Terrarium API credentials, updates password hashing, and increases log file size limit
conf/docker/conf/mc-infra-manager/cloud_conf.yaml Adds k8scluster configuration for cloud providers, corrects GitHub repository URLs, and renames NLB configuration parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

threshold: "3"
k8scluster:
enable: "n"
cloudit :
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing tab character after 'cloudit'. The inconsistent whitespace could cause parsing issues.

Suggested change
cloudit :
cloudit:

Copilot uses AI. Check for mistakes.
## Set etcd cluster
export TB_ETCD_ENDPOINTS=http://localhost:2379
export TB_ETCD_AUTH_ENABLED=true
export TB_ETCD_AUTH_ENABLED=false
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting TB_ETCD_AUTH_ENABLED to false disables authentication for etcd. This could expose the etcd cluster to unauthorized access. Consider keeping authentication enabled unless there's a specific reason to disable it in this environment.

Suggested change
export TB_ETCD_AUTH_ENABLED=false
export TB_ETCD_AUTH_ENABLED=true

Copilot uses AI. Check for mistakes.
@seokho-son
Copy link
Member Author

Let me merge this PR as is considering that

no additional review is required since the content is from

and need to expedite subsystem integrations.

@seokho-son seokho-son merged commit b089729 into m-cmp:main Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant