Skip to content

Set access token claim on HTTP request context#9

Merged
stephen-soltesz merged 5 commits intomasterfrom
sandbox-soltesz
Mar 13, 2020
Merged

Set access token claim on HTTP request context#9
stephen-soltesz merged 5 commits intomasterfrom
sandbox-soltesz

Conversation

@stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Mar 12, 2020

This changes how the token controller validates access tokens.

  1. The token issuer is configured via a flag.

  2. Claims are validated without an explicit "Subject".

    • The claim subject will be used differently for various use-cases, such as for monitoring, a specific IP address in the envelope service, or target service like "ndt".
  3. Claims are saved in the HTTP request context value using SetClaim() and can be retrieved using GetClaim().


This change is Reviewable

@stephen-soltesz stephen-soltesz requested a review from yachang March 12, 2020 20:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 99.107%

Totals Coverage Status
Change from base Build 13: 0.03%
Covered Lines: 222
Relevant Lines: 224

💛 - Coveralls

Copy link

@yachang yachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 approvals obtained (waiting on @yachang)

Copy link

@yachang yachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @yachang)

@stephen-soltesz stephen-soltesz merged commit 88ce58b into master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants