refactor(cache)!: re-introduce CacheEntry#65
Merged
bassosimone merged 1 commit intomainfrom Nov 29, 2025
Merged
Conversation
We re-introduce CacheEntry as a container for m-lab data and other companion data. This change makes the library code mostly ready for accommodating other data sources. BREAKING CHANGE: removed `get_mlab_cache_entry` and replaced it with a generic `get_cache_entry` method instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 27 27
Lines 2257 2257
=======================================
Hits 1860 1860
Misses 397 397 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We re-introduce CacheEntry as a container for m-lab data and other companion data. This change makes the library code mostly ready for accommodating other data sources.
BREAKING CHANGE: removed
get_mlab_cache_entryand replaced it with a genericget_cache_entrymethod instead.