Skip to content

fix(pqread.py): allow subdivision1 filtering#93

Merged
bassosimone merged 2 commits intomainfrom
fix/pqread_subdivision1
Dec 23, 2025
Merged

fix(pqread.py): allow subdivision1 filtering#93
bassosimone merged 2 commits intomainfrom
fix/pqread_subdivision1

Conversation

@bassosimone
Copy link
Collaborator

This diff adds support for filtering for subdivision1 and extends the tests to ensure we're testing for it.

While there, notice that the test suite was not adequately testing filtering by columns (i.e., ensuring that we can get the columns we want), thus introduce a fixture file containing expected columns, to improve the tests quality.

This diff adds support for filtering for subdivision1 and
extends the tests to ensure we're testing for it.

While there, notice that the test suite was not adequately
testing filtering by columns (i.e., ensuring that we can get
the columns we want), thus introduce a fixture file
containing expected columns, to improve the tests quality.
@bassosimone bassosimone merged commit f0317c9 into main Dec 23, 2025
5 checks passed
@bassosimone bassosimone deleted the fix/pqread_subdivision1 branch December 23, 2025 09:34
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4ba6f88) to head (3f3e453).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #93   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1838      1853   +15     
=========================================
+ Hits          1838      1853   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants