fix(pqread.py): allow subdivision1 filtering#93
Merged
bassosimone merged 2 commits intomainfrom Dec 23, 2025
Merged
Conversation
This diff adds support for filtering for subdivision1 and extends the tests to ensure we're testing for it. While there, notice that the test suite was not adequately testing filtering by columns (i.e., ensuring that we can get the columns we want), thus introduce a fixture file containing expected columns, to improve the tests quality.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1838 1853 +15
=========================================
+ Hits 1838 1853 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff adds support for filtering for subdivision1 and extends the tests to ensure we're testing for it.
While there, notice that the test suite was not adequately testing filtering by columns (i.e., ensuring that we can get the columns we want), thus introduce a fixture file containing expected columns, to improve the tests quality.