feat(cache): pass cache_manager to IQBCache#97
Merged
bassosimone merged 1 commit intomainfrom Dec 23, 2025
Merged
Conversation
This diff adds a new kwarg to the constructor of IQBCache so that we can configure a remote cache manager. In turn, this allows people using the IQBCache to take advantage of remotely cached queries and fetch them on demand. While there, notice that `MLabCacheReader` is a misnomer because we will soon be able to write the cache as a side effect, so reduce the amount of surprise by renaming it to `MLabCacheManager`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1906 1912 +6
=========================================
+ Hits 1906 1912 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff adds a new kwarg to the constructor of IQBCache so that we can configure a remote cache manager.
In turn, this allows people using the IQBCache to take advantage of remotely cached queries and fetch them on demand.
While there, notice that
MLabCacheReaderis a misnomer because we will soon be able to write the cache as a side effect, so reduce the amount of surprise by renaming it toMLabCacheManager.