Skip to content

doc(openapi.yaml): document /v2/nearest query params#264

Merged
robertodauria merged 2 commits into
mainfrom
doc/openapi
May 21, 2026
Merged

doc(openapi.yaml): document /v2/nearest query params#264
robertodauria merged 2 commits into
mainfrom
doc/openapi

Conversation

@bassosimone
Copy link
Copy Markdown
Member

@bassosimone bassosimone commented May 18, 2026

This commit adds openapi.yaml documentation for the /v2/nearest query params. According to upstream documentation:

ESP and ESPv2 ignore most parameter and type definitions [...]
don't enforce parameter and type definitions [...] and forwards
incoming requests to your API.

Based on this, there should be no functional change.


This change is Reviewable

This commit adds openapi.yaml documentation for the /v2/nearest
query params. According to [upstream documentation][upstream]:

> ESP and ESPv2 ignore most parameter and type definitions [...]
> don't enforce parameter and type definitions [...] and forwards
> incoming requests to your API.

Based on this, there should be no functional change.

[upstream]: https://docs.cloud.google.com/endpoints/docs/openapi/openapi-limitations
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@bassosimone bassosimone requested a review from robertodauria May 18, 2026 17:23
@coveralls
Copy link
Copy Markdown

coveralls commented May 18, 2026

Coverage Report for CI Build 26051276633

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 82.709%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3042
Covered Lines: 2516
Line Coverage: 82.71%
Coverage Strength: 6.18 hits per line

💛 - Coveralls

Thanks @robertodauria for providing a document with the full
inventory of the locate /v2/nearest query flags.
@robertodauria robertodauria merged commit 9b29ae2 into main May 21, 2026
8 checks passed
@robertodauria robertodauria deleted the doc/openapi branch May 21, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants