Skip to content

Conversation

@nkinkade
Copy link
Contributor

@nkinkade nkinkade commented Mar 5, 2024

We are ready to deploy the first dashboard to a public Grafana instance in the measurement-lab project.


This change is Reviewable

We are ready to deploy the first dashboard to a public Grafana instance in the
measurement-lab project.
@nkinkade nkinkade requested a review from stephen-soltesz March 5, 2024 21:32
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nkinkade)


cloudbuild.yaml line 20 at r1 (raw file):

- name: gcr.io/$PROJECT_ID/gcloud-jsonnet-cbif:1.18
  env:
  - PROJECT_IN=mlab-sandbox,mlab-staging,measurement-lab

I'm trusting you've set the SERVER_URL_ROOT substitution for the CB trigger.

Copy link
Contributor Author

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)


cloudbuild.yaml line 20 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

I'm trusting you've set the SERVER_URL_ROOT substitution for the CB trigger.

I did a while ago:

https://console.cloud.google.com/cloud-build/triggers;region=global/edit/bde41724-296d-4dd4-8784-ada10e3986c5?project=measurement-lab

However, I realized that I also need to get the terraform-support changes in place before this repo is tagged, else the grafana-public service account won't exist. I have another PR for this, which I just tagged you on.

@nkinkade nkinkade merged commit 48c47a9 into main Mar 5, 2024
@nkinkade nkinkade deleted the sandbox-kinkade branch March 5, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants