Adds adds a wait operation for deployments to measurement-lab #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A production build failed with this error: > Cannot operate on apps/measurement-lab because an operation is already in progress for apps/measurement-lab Looking at the build step timing compared to the operations in App Engine, there is a very tight timing issue. This commit adds a new build step that waits for the most recent pending operation to complete before moving on to deploying dispatch.yaml. I _believe_ this should safeguard against this particular error condition in the build.
cristinaleonr
approved these changes
Mar 19, 2024
cristinaleonr
left a comment
cristinaleonr
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A production build failed with this error:
Looking at the build step timing compared to the operations in App Engine, there is a very tight timing issue. This commit adds a new build step that waits for the most recent pending operation to complete before moving on to deploying dispatch.yaml. I believe this should safeguard against this particular error condition in the build.
This change is