COFF: fix subtract with overflow in COFF header parser #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkent030315
force-pushed
the
bug/coffhdr
branch
from
e11f88b to
8b1241e
Compare
co-authored-by: dapa <dapa@github>
kkent030315
added a commit
to kkent030315/goblin-experimental
that referenced
this pull request
Mar 26, 2025
Owner
|
ditto also needs a rebase |
Contributor
Author
|
@m4b done, this one maybe conflict again with the one outstanding. mb. |
Owner
|
Sorry does look like it has a conflict :( |
Contributor
Author
|
@m4b done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed subtract with overflow in COFF header parser and added regression test for it.