fix: use correct ISO-DEP block number after response chaining#3
Open
Sped0n wants to merge 2 commits into
Open
Conversation
Signed-off-by: Zhibin (Ryan) Wen <wenzhibin@espressif.com>
6c55e27 to
bebe446
Compare
Signed-off-by: Zhibin (Ryan) Wen <wenzhibin@espressif.com>
bebe446 to
855dfdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ISO-DEP response chaining did not keep the PCD block number synchronized with the final PICC I-block. After receiving a chained response, the next command could be sent with the wrong I-block BN, causing protocol desync with cards that return multi-frame responses.
Change Overview
transceiveINF().Testing
Tested on M5NanoC6 with Unit NFC:
platformio test -e test_UnitNFC_NanoC6 --upload-port /dev/ttyACM0 --test-port /dev/ttyACM0,146/146test cases passed.