Skip to content

fix(android): same callback logic between showModal options #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mCodex merged 1 commit into from
Jul 29, 2020
Merged

fix(android): same callback logic between showModal options #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions android/src/main/java/br/com/classapp/RNSensitiveInfo/RNSensitiveInfoModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,8 @@ public void onAuthenticationError(int errorCode, @NonNull CharSequence errString

@Override
public void onAuthenticationFailed() {
pm.reject(AppConstants.E_AUTHENTICATION_NOT_RECOGNIZED, strings.containsKey("notRecognized") ? strings.get("notRecognized").toString() : "Fingerprint not recognized, try again");
getReactApplicationContext().getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
.emit("FINGERPRINT_AUTHENTICATION_HELP", "Fingerprint not recognized.");
}
}

Expand Down Expand Up @@ -476,7 +477,8 @@ public void onAuthenticationError(int errorCode, @NonNull CharSequence errString

@Override
public void onAuthenticationFailed() {
pm.reject(AppConstants.E_AUTHENTICATION_NOT_RECOGNIZED, strings.containsKey("notRecognized") ? strings.get("notRecognized").toString() : "Fingerprint not recognized, try again");
getReactApplicationContext().getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)
.emit("FINGERPRINT_AUTHENTICATION_HELP", "Fingerprint not recognized.");
}
}

Expand Down
1 change: 0 additions & 1 deletion android/src/main/java/br/com/classapp/RNSensitiveInfo/utils/AppConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ public interface AppConstants {
String DIALOG_FRAGMENT_TAG = "authFragment";

// error codes
String E_AUTHENTICATION_NOT_RECOGNIZED = "E_AUTHENTICATION_NOT_RECOGNIZED";
String E_AUTHENTICATION_CANCELLED = "E_AUTHENTICATION_CANCELLED";
String E_INIT_FAILURE = "E_INIT_FAILURE";
}