feat: add config merging#5
Conversation
Summary of ChangesHello @mKeRix, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the configuration management system by introducing the ability to load and merge settings from multiple configuration files. This change provides greater flexibility, allowing users to define global preferences and project-specific overrides seamlessly. The new mechanism supports a familiar hierarchical configuration pattern, similar to other development tools, and ensures that configuration loading is robust with improved path parsing, tilde expansion, and error handling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 52.61% 53.28% +0.67%
==========================================
Files 33 33
Lines 2313 2357 +44
Branches 142 156 +14
==========================================
+ Hits 1217 1256 +39
- Misses 1096 1101 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Code Review
This pull request introduces a well-designed feature for merging multiple configuration files, allowing for both user-level and project-level settings. The implementation is robust, with comprehensive design documents, specifications, and tests. The core logic for path parsing, file loading, and merging is clean and effective. The CLI commands are correctly updated to support the new functionality. I have one point of feedback regarding a discrepancy between the implementation and the specification on when environment variable substitution occurs, which should be addressed to ensure long-term maintainability.
# 1.0.0 (2025-12-01) ### Features * add config merging ([#5](#5)) ([4d58cb7](4d58cb7)) * add semantic tool search ([#2](#2)) ([cac523b](cac523b)) * allow filtering exposed tools ([#4](#4)) ([bd1d64c](bd1d64c)) * implement code mode ([#1](#1)) ([b3c4646](b3c4646)) * initial commit ([5477138](5477138)) * support oauth2 protected mcp servers ([#3](#3)) ([f5408d1](f5408d1))
# 1.0.0 (2025-12-01) ### Features * add config merging ([#5](#5)) ([4d58cb7](4d58cb7)) * add semantic tool search ([#2](#2)) ([cac523b](cac523b)) * allow filtering exposed tools ([#4](#4)) ([bd1d64c](bd1d64c)) * implement code mode ([#1](#1)) ([b3c4646](b3c4646)) * initial commit ([5477138](5477138)) * support oauth2 protected mcp servers ([#3](#3)) ([f5408d1](f5408d1))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This adds merging multiple file to the config mechanism, which allows for shared configs between multiple projects a user is working on. By default, the .toolscript.json files will be loaded from the user home dir and current dir now.