Skip to content

ci: add in missing GPG step for updating submodules#238

Merged
mchuangatmp merged 2 commits intodevelopmentfrom
ci/SQDSDKS-4552
Sep 16, 2022
Merged

ci: add in missing GPG step for updating submodules#238
mchuangatmp merged 2 commits intodevelopmentfrom
ci/SQDSDKS-4552

Conversation

@mchuangatmp
Copy link
Copy Markdown
Contributor

@mchuangatmp mchuangatmp commented Sep 16, 2022

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-branch-check-name.yml

Summary

  • add in missing GPG step for updating submodules

Testing Plan

  • regression tests should pass

Reference Issue

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

einsteinx2
einsteinx2 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchuangatmp mchuangatmp merged commit ac9ee19 into development Sep 16, 2022
@mchuangatmp mchuangatmp deleted the ci/SQDSDKS-4552 branch September 16, 2022 17:54
github-actions Bot pushed a commit that referenced this pull request Sep 26, 2022
@mparticle-automation
chore(release): 5.45.2
872f7d6 
## [5.45.2](v5.45.1...v5.45.2) (2022-09-26)

### Updates & Maintenance

* add in missing GPG step for updating submodules ([#238](#238)) ([ac9ee19](ac9ee19))
* Update submodules ([cf4d2e0](cf4d2e0))
@mparticle-automation
Copy link
Copy Markdown
Collaborator

mparticle-automation commented Sep 26, 2022

🎉 This PR is included in version 5.45.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchuangatmp @mparticle-automation @einsteinx2