-
Notifications
You must be signed in to change notification settings - Fork 72
feat: Add scripts to analyze project test coverage #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nickolas-dimitrakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, discussed in-person with walkthrough and everything works as expected.
|
@jamesnrokt and @rmi22186 The implementation here is solid but if we'd prefer to use codeCov it doesn't make much sense to merge this. Should we schedule a meeting to decide this or have we already landed on one or the other? More info from Denis on this where he compared the 2 |
Will you guys have chance to sync tomorrow? |
|
My understanding is the current script in this PR is primarily for local development feedback to ensure PRs have a certain level of code coverage before pushing the branch up. Whereas codecov could be used to fail CI/CD if a certain level of code coverage is not attained. Is that accurate @denischilik |
|
That is true but not only for that, it will be also important during
refactoring steps because we will need to understand if all implementation
files have their related tests and to test that we maintain the same folder
structure which we have for source files. Additionally it will be important
to add test coverage limits for specific files.
…On Thu, Aug 14, 2025 at 10:32 AM Robert Ing ***@***.***> wrote:
*rmi22186* left a comment (mParticle/mparticle-apple-sdk#388)
<#388 (comment)>
My understanding is the current script in this PR is primarily for local
development feedback to ensure PRs have a certain level of code coverage
before pushing the branch up. Whereas codecov could be used to fail CI/CD
if a certain level of code coverage is not attained. Is that accurate
@denischilik <https://github.com/denischilik>
—
Reply to this email directly, view it on GitHub
<#388 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BVUVHI7RODAZ2VV2APQJAS33NSMZJAVCNFSM6AAAAACDTPV5ZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBYGY3TKNBXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Denis Chilik *
[image: Rokt] <https://www.rokt.com>
*M.* 2019529613
*A.* 175 Varick Street, Level 10, New York, NY 10014
<https://goo.gl/maps/EysMyzeDj6qyUQy49>
|
|
🎉 This PR is included in version 8.38.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
check_coverage.shandcheck_coverage.pyto build project coverage reportcheck_coverage.shfrom build folder.check_coverage.pycontainsCOVERAGE_THRESHOLDwhich is used to highlight files with red if coverage less the threshold.Testing Plan
check_coverage.shfrom build folder.Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)