Skip to content

fix(ios): remove SPM duplicate for mParticle-Apple-SDK#309

Merged
nickolas-dimitrakas merged 1 commit intomainfrom
fix/308-remove-spm-mparticle-duplicate
Apr 15, 2026
Merged

fix(ios): remove SPM duplicate for mParticle-Apple-SDK#309
nickolas-dimitrakas merged 1 commit intomainfrom
fix/308-remove-spm-mparticle-duplicate

Conversation

@nickolas-dimitrakas
Copy link
Copy Markdown
Contributor

Summary

Removes the spm_dependency block from react-native-mparticle.podspec. iOS continues to use the existing CocoaPods dependency on mParticle-Apple-SDK.

Why

React Native’s SPM bridge pulled the same Apple SDK xcframework alongside CocoaPods, which led to duplicate mParticle_Apple_SDK.xcframework-ios.signature collection and Release archive failures (including EAS).

Closes

Closes #308

Made with Cursor

CocoaPods already resolves mParticle-Apple-SDK. The RN spm_dependency
hook pulled the same xcframework twice, which broke Release archives
(EAS) with duplicate .signature files.

Closes #308

Made-with: Cursor
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner April 15, 2026 14:44
Copilot AI review requested due to automatic review settings April 15, 2026 14:44
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 15, 2026

PR Summary

Low Risk
Low risk: changes only the CocoaPods spec to stop declaring an additional SPM dependency; impact is limited to iOS build/linkage behavior.

Overview
Removes the React Native SPM bridge declaration for mParticle-Apple-SDK from react-native-mparticle.podspec, leaving only the CocoaPods dependency ('~> 8.0').

This prevents iOS builds from pulling the same mParticle XCFramework via both CocoaPods and SPM, reducing duplicate-artifact/archive failures.

Reviewed by Cursor Bugbot for commit 06d4284. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the React Native SPM bridge registration for mParticle-Apple-SDK from the module podspec to prevent SPM + CocoaPods from pulling the same xcframework twice (fixing archive/signature collisions).

Changes:

  • Remove the spm_dependency block for mParticle-Apple-SDK from react-native-mparticle.podspec
  • Keep mParticle-Apple-SDK as a CocoaPods dependency (~> 8.0)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nickolas-dimitrakas nickolas-dimitrakas merged commit 37d1db5 into main Apr 15, 2026
15 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the fix/308-remove-spm-mparticle-duplicate branch April 15, 2026 15:24
@rokt-releases rokt-releases bot mentioned this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EAS iOS Build Failures - Signature Collision

3 participants