Skip to content

fix: pin android-core upper bound to prevent 6.0.0-rc.1 pull (#710)#329

Merged
nickolas-dimitrakas merged 1 commit into
mainfrom
chore/pin-mparticle-version-range-rc1
May 27, 2026
Merged

fix: pin android-core upper bound to prevent 6.0.0-rc.1 pull (#710)#329
nickolas-dimitrakas merged 1 commit into
mainfrom
chore/pin-mparticle-version-range-rc1

Conversation

@jamesnrokt
Copy link
Copy Markdown
Contributor

Summary

Why

com.mparticle:android-core:6.0.0-rc.1 was published to Maven Central on 2026-05-22. The open-ended range resolves to the highest available version, which is now the RC. 6.x removed deprecated symbols including com.mparticle.UserAttributeListener (referenced by this module), so consumers who built successfully before 2026-05-22 are now broken with no change on their side:

error: cannot find symbol
import com.mparticle.UserAttributeListener;
                    ^
  symbol:   class UserAttributeListener

The bounded upper bound restores the previous behavior and gates 6.x adoption behind an explicit version bump in this module.

Test plan

  • cd android && ./gradlew assembleRelease succeeds (was failing with cannot find symbol: UserAttributeListener).
  • Consumer repro from issue #710 builds again after upgrading to the version that contains this fix.

🤖 Generated with Claude Code

The open-ended `[5.79.0, )` range resolves to the highest available
version on Maven Central — which is now `6.0.0-rc.1` (published
2026-05-22). 6.x removed deprecated symbols including
`com.mparticle.UserAttributeListener`, breaking this module's compile.

Fixes #710. Consumers who built successfully before 2026-05-22 are now
broken without any change on their side; this pin restores them.

Closes mParticle/mparticle-android-sdk#710

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 27, 2026 19:44
@jamesnrokt jamesnrokt requested a review from a team as a code owner May 27, 2026 19:44
@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Gradle version-range only; no runtime logic changes, and it reduces accidental breakage from resolving 6.x RCs.

Overview
Pins the transitive com.mparticle:android-core dependency in android/build.gradle from an open-ended [5.79.0, ) range to [5.79.0, 6.0), with comments tying the cap to Maven Central resolving 6.0.0-rc.1 and 6.x dropping APIs such as UserAttributeListener (used by MParticleModule.kt).

This restores builds for apps that pull this React Native module without pinning core themselves, and defers adopting 6.x until this bridge is updated explicitly.

Reviewed by Cursor Bugbot for commit ebec470. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ebec470. Configure here.

Comment thread android/build.gradle
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent Gradle from resolving com.mparticle:android-core to newly published 6.x pre-releases (notably 6.0.0-rc.1) by adding an upper bound to the dependency version range in the React Native mParticle Android module.

Changes:

  • Add an upper bound to the com.mparticle:android-core dependency range in android/build.gradle.
  • Add inline comments explaining why the upper bound was introduced (6.x removal of deprecated symbols).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread android/build.gradle
Comment thread android/build.gradle
@nickolas-dimitrakas nickolas-dimitrakas merged commit 121f45a into main May 27, 2026
12 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the chore/pin-mparticle-version-range-rc1 branch May 27, 2026 20:28
@rokt-releases rokt-releases Bot mentioned this pull request May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New 6.0.0-rc.1 broke Android builds in React Native

5 participants