Skip to content

Conversation

@xLPMG
Copy link

@xLPMG xLPMG commented Dec 6, 2025

Fixes most build issues. Remaining issues are:

  • Linux Qt6 Core build: the newly added files require further dependencies. I'm not sure how to solve this without bloating the core build
  • Qt5 builds: QList and QPolygonF& are mixed. While Qt6 doesnt seem to have a problem with this, Qt5 does. This should be fixed but is not directly related to cmake

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@xLPMG xLPMG marked this pull request as ready for review December 6, 2025 11:31
@mRaetz mRaetz merged commit df7b828 into mRaetz:new-SkycultureMenu Dec 6, 2025
5 checks passed
@xLPMG xLPMG deleted the qt-svg-widgets branch December 11, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants