Skip to content

Fix build issues#65

Merged
joocer merged 1 commit intomainfrom
copilot/update-jsonl-reader-draken-vectors
Oct 26, 2025
Merged

Fix build issues#65
joocer merged 1 commit intomainfrom
copilot/update-jsonl-reader-draken-vectors

Conversation

@joocer
Copy link
Member

@joocer joocer commented Oct 26, 2025

This pull request updates the CI configuration for building and testing Python wheels, with a focus on refining supported Python versions and improving compatibility for aarch64 builds. The main changes involve skipping Python 3.9 in tests, adjusting test skips for certain architectures and Python versions, and updating the runner environment for aarch64 builds.

Python version and architecture support updates:

  • The test matrix in .github/workflows/test.yml now excludes Python 3.9, limiting tests to Python 3.10 and newer.
  • In .github/workflows/release.yml, the CIBW_TEST_SKIP configuration is updated to skip tests for Python 3.10 and specific Linux architectures (ppc64le, s390x).
  • For aarch64 builds, tests for Python 3.10 wheels are explicitly skipped in the dry-run build identifier step.

Build environment improvements:

  • The runner for the build_wheels_aarch64 job is changed from ubuntu-latest to ubuntu-24.04-arm64, ensuring native arm64 builds.
  • Redundant QEMU and Docker Buildx setup steps are removed from the aarch64 build job, simplifying the workflow.

Copilot AI review requested due to automatic review settings October 26, 2025 08:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Python 3.9 support from the CI/CD pipeline and optimizes the ARM64 wheel building process by switching to native ARM64 runners instead of using QEMU emulation.

Key Changes:

  • Removed Python 3.9 from the test matrix
  • Migrated ARM64 wheel building from emulated (QEMU) to native ARM64 runners
  • Added Python 3.10 test skipping for specific build configurations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/test.yml Removed Python 3.9 from the test matrix
.github/workflows/release.yml Changed ARM64 builds to use native runners, removed QEMU setup, and added test skip configurations for Python 3.10

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -37,7 +37,7 @@ jobs:
CIBW_SKIP: "pp* *-manylinux_i686"
CIBW_BEFORE_BUILD: "pip install -U pip setuptools wheel Cython"
CIBW_TEST_COMMAND: "python -c \"import rugo.parquet; print('Import successful')\""
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The pattern cp310-* skips all Python 3.10 builds across all platforms, but it appears alongside platform-specific exclusions. Consider separating these into distinct skip patterns for clarity, e.g., CIBW_TEST_SKIP: 'cp310-* *-*linux_{ppc64le,s390x}' could be split or documented to clarify that cp310 is globally skipped while the linux exclusions are platform-specific.

Suggested change
CIBW_TEST_COMMAND: "python -c \"import rugo.parquet; print('Import successful')\""
CIBW_TEST_COMMAND: "python -c \"import rugo.parquet; print('Import successful')\""
# cp310-* skips all Python 3.10 builds globally; *-*linux_{ppc64le,s390x} skips only on specific Linux platforms

Copilot uses AI. Check for mistakes.
CIBW_SKIP: "pp* *-manylinux_i686"
CIBW_BEFORE_BUILD: "pip install -U pip setuptools wheel Cython"
CIBW_TEST_COMMAND: "python -c \"import rugo.parquet; print('Import successful')\""
CIBW_TEST_SKIP: "cp310-*"
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The CIBW_TEST_SKIP for Python 3.10 (cp310-*) is duplicated between the x86_64 build (line 40) and the aarch64 build (line 75). Consider defining this as a shared environment variable or workflow-level variable to maintain consistency and reduce duplication.

Copilot uses AI. Check for mistakes.
@joocer joocer merged commit cfb05c3 into main Oct 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants