Skip to content

add wait method for loading image #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djbf merged 1 commit into from
May 12, 2020
Merged

add wait method for loading image #42

djbf merged 1 commit into from
May 12, 2020

Conversation

@daipresents
Copy link
Contributor

@daipresents daipresents commented May 12, 2020

need a parameter of class name from outside of this Javascript.

  • Wait until loading image disappears.
  • MAX_WAIT_SEC is waiting time and you can set it for your environment.
  • If the element exist until MAX_WAIT_SEC, finish this function and return false.

@djbf djbf merged commit fbce3f3 into mablhq:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@djbf djbf djbf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daipresents @djbf