Cancel modal bug #203
Merged
Cancel modal bug #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I'll bump patch version as well |
mac-s-g
commented
Jul 2, 2018
| this.setState({ | ||
| validationFailure: false | ||
| validationFailure: false, | ||
| addKeyRequest: false |
Owner
Author
There was a problem hiding this comment.
this used to work by setting state directly at render time in index.js.
it was a hack. definitely looks better now.
franklixuefei
approved these changes
Jul 2, 2018
Collaborator
|
@mac-s-g when you have time, could you publish this? |
Owner
Author
|
thanks! i'll publish now |
Owner
Author
|
published to + react-json-view@1.18.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #202