Skip to content

Cancel modal bug #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2018
Merged

Cancel modal bug #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d3c187
bug fix for broken cancel button
mac-s-g Jul 2, 2018
04eb222
Merge branch 'master' into cancel-modal-bug
mac-s-g Jul 2, 2018
bb75a5b
bump patch
mac-s-g Jul 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "react-json-view",
"description": "Interactive react component for displaying javascript arrays and JSON objects.",
"version": "1.18.1",
"version": "1.18.2",
"main": "dist/main.js",
"dependencies": {
"flux": "^3.1.3",
Expand Down
3 changes: 2 additions & 1 deletion src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ class ReactJsonView extends React.PureComponent {

resetState = () => {
this.setState({
validationFailure: false
validationFailure: false,
addKeyRequest: false
Copy link
Owner Author

@mac-s-g mac-s-g Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this used to work by setting state directly at render time in index.js.
it was a hack. definitely looks better now.

Copy link
Collaborator

@franklixuefei franklixuefei Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

});
}
}
Expand Down