fix(e2e): use unique SSM paths per CLI test run to prevent race conditions#130
Merged
fix(e2e): use unique SSM paths per CLI test run to prevent race conditions#130
Conversation
…tions Concurrent CI runs shared hardcoded SSM paths (/Test/Token, /Test/SingleVariable) against real AWS SSM, causing ParameterNotFound errors when one run's cleanup deleted parameters another run had just created. Each test run now generates a unique runId and creates temporary map files with isolated SSM paths (/Test/<runId>/Token). Temp files are cleaned up in afterAll.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Replace sync map-file writes with async Promise.all in beforeAll and use forced rm cleanup in afterAll. This avoids blocking file IO and simplifies teardown for ephemeral test artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concurrent CI runs of
e2e/cli.test.tsshared hardcoded SSM paths (/Test/Token,/Test/SingleVariable) against real AWS SSM. When two runs overlapped, one run'scleanUpSsmcould delete parameters that another run had just created, causing flakyParameterNotFounderrors in the Assert phase.This fix generates a unique
runIdper test run and creates temporary map files with isolated SSM paths, eliminating the race condition.Changes
runId(randomUUID().slice(0, 8)) at describe-block scope/Test/<runId>/Tokenand/Test/<runId>/SingleVariablebeforeAll(param-map-<runId>.json,param-map-with-aws-config-<runId>.json)afterAllTesting
pnpm testpasses (19/19 unit test files)pnpm lintpassespnpm buildpassesRelated
Fixes flaky
Should_GenerateEnvironmentFile_When_ValidArgumentsAreProvidedfailure observed in publish-action CI workflow.