Skip to content

fix(e2e): use separate env file for GHA tests#159

Merged
macalbert merged 1 commit intomainfrom
fix/e2e-gha-env-file-collision
Apr 15, 2026
Merged

fix(e2e): use separate env file for GHA tests#159
macalbert merged 1 commit intomainfrom
fix/e2e-gha-env-file-collision

Conversation

@macalbert
Copy link
Copy Markdown
Owner

@macalbert macalbert commented Apr 15, 2026

Description

Give the GHA E2E test suite its own output env file to avoid collisions with the CLI suite.

Type of Change

  • Bug fix

Changes Made

  • Rename GHA test output from cli-validation.envgha-validation.env in e2e/gha.test.ts

Root Cause

Both CLI and GHA E2E suites wrote to the same cli-validation.env file, which can cause file collisions when tests run in parallel.

Checklist

  • Code follows project conventions
  • No breaking changes

Open with Devin

CLI and GHA E2E suites both wrote to cli-validation.env, which can
cause file collisions when tests run in parallel. Give the GHA suite
its own gha-validation.env output path.
Copilot AI review requested due to automatic review settings April 15, 2026 09:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • e2e/gha.test.ts is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f066907c-ae39-4385-97f8-fcb65143a778

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-gha-env-file-collision

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Action E2E test suite to write its output to a distinct .env file so it doesn’t conflict with the CLI E2E suite when tests run in parallel.

Changes:

  • Renamed the GHA E2E env output file from cli-validation.env to gha-validation.env in e2e/gha.test.ts.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the environment file path in the GitHub Action E2E tests from cli-validation.env to gha-validation.env. I have no feedback to provide.

@macalbert macalbert merged commit fc4d2fc into main Apr 15, 2026
9 checks passed
@macalbert macalbert deleted the fix/e2e-gha-env-file-collision branch April 15, 2026 10:06
@macalbert macalbert self-assigned this Apr 15, 2026
@macalbert macalbert added the bug Something isn't working label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants