Skip to content

Basic auth#103

Merged
macbre merged 2 commits intomacbre:develfrom
gmetais:basic-auth
Jul 18, 2015
Merged

Basic auth#103
macbre merged 2 commits intomacbre:develfrom
gmetais:basic-auth

Conversation

@gmetais
Copy link
Copy Markdown
Contributor

@gmetais gmetais commented Jul 17, 2015

Adding basic http authentication to analyze-css. This is the first step to macbre/phantomas#500 (comment)

An idea on how to proxify a request with 'http' and 'https' modules?

Didn't write tests because it's kind of hard to simulate...

@macbre
Copy link
Copy Markdown
Owner

macbre commented Jul 18, 2015

👍

macbre pushed a commit that referenced this pull request Jul 18, 2015
@macbre macbre merged commit e091097 into macbre:devel Jul 18, 2015
@macbre macbre added this to the v0.10 milestone Jul 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants