Enhance binary data handling and update neo-client dependency#408
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
+ Coverage 62.87% 63.76% +0.89%
==========================================
Files 352 352
Lines 68649 68892 +243
==========================================
+ Hits 43161 43929 +768
+ Misses 20915 20345 -570
- Partials 4573 4618 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Introduced ContextWithEventLoop and EventLoopFromContext functions to manage event loop context. - Updated RegisterNativeModule to utilize the new context functions. - Modified HTTP module to pass the event loop to NewServer. - Enhanced WebSocket handling to support event loop execution for callbacks. - Refactored MqttBridge and NatsBridge to use atomic operations for connection state management. - Improved SubscriberEntry and TimerEntry to use new state management methods for better concurrency safety.
…rove shutdown handling
…uter, pretty table, MQTT and NATS bridges, and scheduler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a unified and configurable approach to binary data formatting across table, CSV, and JSON exporters, along with improvements to append worker management. The main changes include the addition of a
binaryformatoption for table and CSV outputs, the refactoring of binary formatting logic to use a sharedBinaryFormatterutility, and the implementation of a more robust mechanism for stopping append workers by table name. Several tests have been added or updated to ensure these new features work as expected.Binary formatting improvements:
binaryformatoption (supportsbase64,hex,bytes,preview) to table (jsh/lib/pretty/box.go,jsh/lib/pretty/pretty.js) and CSV exporters, allowing users to control how binary data is displayed. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]util.BinaryFormatter, replacing previous ad-hoc or duplicated logic. [1] [2] [3] [4]Append worker management:
appendersControlchannel andAppendWorkerControlstruct to allow stopping append workers for specific tables in a thread-safe and synchronous manner, along with a newStopAppendWorkerfunction. [1] [2] [3]Dependency updates:
github.com/machbase/neo-clientto a newer development version ingo.mod.