update dependencies and enhance connection handling in metrics#433
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 65.40% 65.46% +0.05%
==========================================
Files 351 351
Lines 69696 69720 +24
==========================================
+ Hits 45585 45640 +55
+ Misses 19264 19229 -35
- Partials 4847 4851 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the connection pooling, metrics collection, and SQL driver testing subsystems. The most significant changes include making the metrics collector non-blocking under load, improving connection pool error handling and configuration, and expanding test coverage for SQL wrappers and connection pooling.
Metrics Collection Improvements:
Collectorinmetric.gonow uses a much larger buffer (recvChSizeincreased from 100 to 10,000) and is non-blocking: if the buffer is full, new measurements are dropped and a counter is incremented to track how many were dropped. This prevents request goroutines from blocking due to backpressure. A new method,DroppedCount(), exposes the number of dropped measurements. Unit tests verify this behavior. [1] [2] [3] [4] [5]Connection Pooling and Error Handling:
Retry-Afterheader, rather than falling back to a direct connection.Testing and SQL Wrapper Enhancements:
Dependency Update:
github.com/machbase/neo-clientdependency is updated to a newer version.These changes collectively improve system robustness under load, provide better observability for connection pooling, and increase test reliability and coverage.