Fix hm2 spi #213
Merged
Fix hm2 spi #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hm2_bspi_setup_chan(): Change clock divisor mask to 8 bits
: transfer length field is 6 bits wide
Fixes: hm2_bspi_write_chan(): sending random values
hm2_bspi_setup_chan(): having uncorrect spi clock rates
And whitespace cleanup
Signed-off-by: Michael Brown <producer@holotronic.dk>
Signed-off-by: Michael Brown <producer@holotronic.dk>
…ptor Signed-off-by: Michael Brown <producer@holotronic.dk>
Signed-off-by: Michael Brown <producer@holotronic.dk>
Contributor
|
Looks fine to me, but I will leave @cdsteinkuehler to look at this and machinekit/mksocfpga#106 together. |
Contributor
|
@cdsteinkuehler is obviously away - tested so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found 2 bugs trying to implement spi functionality on the mksocfpga.
Then looked at the bspi.c file history in Linuxcnc:
https://github.com/LinuxCNC/linuxcnc/commits/master/src/hal/drivers/mesa-hostmot2/bspi.c
And found the same fixes and some additional enhancements I added also.
Lastly I added support for the dbspi (buffered spi's with decoded chip selects), as a separete file.
Tested to work on Mksocfpga.