Skip to content

Conversation

@the-snowwhite
Copy link
Contributor

I also removed the ADC core from qsys, in the db25 projects it could be relevant to place it in the hm2 core similar to in the _Cramps projects this would gain hm2 support from the drivers already placed in the hal.

Would it be relevant to hang a qsys address map up somewhere and also a verbose description of the related device-trees ?

Changed lcd_pll clock to 65 MHz in _FB_Cramps project,
Added missing reset lines.

Signed-off-by: Michael Brown <producer@holotronic.dk>
Signed-off-by: Michael Brown <producer@holotronic.dk>
Signed-off-by: Michael Brown <producer@holotronic.dk>
Signed-off-by: Michael Brown <producer@holotronic.dk>
Copy link
Contributor

@ArcEye ArcEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave @cdsteinkuehler to review the content.

Will check package handling and allocation once the build finishes.

@ArcEye
Copy link
Contributor

ArcEye commented Jun 8, 2018

@the-snowwhite
I am happy to merge if you need the package to continue work.
It can always be reverted if there is a problem.

The main change appears to be removal of some ADC items which presumably are not in use anyway?

I have no idea as to @cdsteinkuehler's availability or when he will have time to review.

@cdsteinkuehler cdsteinkuehler merged commit efd3e36 into machinekit:master Jun 8, 2018
@cdsteinkuehler
Copy link
Contributor

Sorry, I was in the Tennessee mountains on vacation.

Looks good. Having the qsys addresses be consistent is a good idea. I probably would have left the ADC stuff alone, but I don't think it's being used so removing it isn't a problem.

Merged.

@ArcEye
Copy link
Contributor

ArcEye commented Jun 8, 2018

I have the Jenkins build in one of my browser windows and will check what happens to the package once completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants