Skip to content

Fix version in CMakeLists.txt#467

Merged
bsergean merged 2 commits intomachinezone:masterfrom
lanthora:fix-version-in-cmakelists
Jun 5, 2023
Merged

Fix version in CMakeLists.txt#467
bsergean merged 2 commits intomachinezone:masterfrom
lanthora:fix-version-in-cmakelists

Conversation

@lanthora
Copy link
Copy Markdown
Contributor

No description provided.

@flagarde
Copy link
Copy Markdown
Contributor

Maybe this version infos could be added inside the project command for simplicity ?

@lanthora
Copy link
Copy Markdown
Contributor Author

Maybe this version infos could be added inside the project command for simplicity ?

I don't know what the "project command" means.

Usually Linux users use the following command to compile and install:

cmake ../
make
make install

Do you mean to specify the version number through the parameter when executing the cmake command?

cmake -DVERSION=x.x.x ../

I don't think it's a good idea to let the user decide the version number.

@flagarde
Copy link
Copy Markdown
Contributor

I mean the project command inside CMakeLists can have a version https://cmake.org/cmake/help/latest/command/project.html

Which can be iseful as it is easily to see and have parameter dedicated by CMAke for this usage

@lanthora
Copy link
Copy Markdown
Contributor Author

It looks ok now

@lanthora
Copy link
Copy Markdown
Contributor Author

lanthora commented Jun 5, 2023

@bsergean IXHttpClientTest always fails recently, the master branch only modified the README file when all CIs failed last time. It may be a problem with the test server

@bsergean bsergean merged commit 397bb5d into machinezone:master Jun 5, 2023
@lanthora lanthora deleted the fix-version-in-cmakelists branch July 19, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants