Conversation
…m_ip - Add 10 new test cases covering edge cases and documentation scenarios - Add TestXFFEdgeCases class with tests for: * Whitespace and empty X-Forwarded-For headers * Invalid IP formats in X-Forwarded-For * IPv6 support in X-Forwarded-For * Whitespace handling in header values * Integration with other rule conditions * IPv6 CIDR support for xff_upstream_ip * Behavior without source_ip restrictions - Add TestXFFDocumentationScenarios class with tests validating: * Example 7 from README (load balancer scenario) * Multi-network access with X-Forwarded-For - Create xff_example.yaml rules file demonstrating proper xff configuration - Create protected_xff_example.txt file for the example rule - All 57 tests pass successfully Co-authored-by: maclarel <21298298+maclarel@users.noreply.github.com>
Removed duplicate assignment that was flagged in code review for improved code clarity. Co-authored-by: maclarel <21298298+maclarel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update test coverage for use_xff and xff_upstream_ip
Add comprehensive test coverage and example configuration for X-Forwarded-For
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing XFF tests covered basic functionality but lacked edge case validation and practical configuration examples.
Test Coverage
Added 10 tests across two new test classes:
TestXFFEdgeCases - Validates handling of:
TestXFFDocumentationScenarios - Validates:
Example Configuration
Added
rules/xff_example.yamldemonstrating:Total test count: 47 → 57 tests, all passing.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.